Fixes #128 - #129
Merged
Merged
Conversation
Make a 'not supported field type' exception more readable, so the developer could figure out why he can't load the data
markusweimer
approved these changes
May 11, 2018
Contributor
|
thanks! looks good. |
glebuk
self-requested a review
May 11, 2018 18:38
glebuk
approved these changes
May 11, 2018
Contributor
|
Thanks for this contribution. Please for future PRs make sure that the title has something about the work done rather than just referencing the issue. |
Contributor
Author
|
Oh... Sure! |
Contributor
|
cheers :) |
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
Make a 'not supported field type' exception more readable, so the developer could figure out why he can't load the data This closes dotnet#128
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a 'not supported field type' exception more readable, so the developer could figure out why he can't load the data. This should make learning curve smoother for an incoming developer